Returns grainstats rows when tracing for a grain fails #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ns-rse
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Excellent, glad that has worked, thanks for doing this so quickly @MaxGamill-Sheffield
MaxGamill-Sheffield
deleted the
maxgamill-sheffield/failed-DT-drops-grainstats-row
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TopoStats Pull Requests
Closes #1028
This uses "outer" merges instead of "inner" merges so that when combining the grainstats dataframe for the additional stats in the tracing pipeline, they are appended correctly when a grain may have an error in the tracing pipeline e.g. when a grain fails skeletonisation.
A test case for this was to add into the disordered tracing code:
And now the grainstats are present for this molecule, but the tracing stats a empty whereas before the entire row was dropped, but I'm not quite sure how to add this into the testing code as all the mergers are not yet covered and we'd have to have a grain purposefully fail.
Either way, this is now resolved.