Adds nbQA to pre-commit hooks #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opted not to apply `nbqa-mypy` for type hints in Notebooks and have disabled `nbqa-pylint` for the time being.
Applied some of the linting rules that `pylint` reported but not all, the environment used doesn't have TopoStats installed and so fails (just as `pylint` would fail in `pre-commit.ci` and is therefore configured as `local` only). Have opted to remove `nbqa-pylint` hook but have removed unused imports from Notebooks.
Sets `max-line-length` to 120 for `flake8` via `tox.ini` and addresses most other errors reported by `flake8`. The exception is a single equality condition used to subset a Pandas Dataframe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1038
Opted not to apply
nbqa-mypyfor type hints in Notebooks and have disablednbqa-pylintfor the time being. The laterbecause the environment doesn't have all the dependencies included and so
pylintcomplains about not being able toimport
topostats.modulesChecked all hooks pass and linted the existing notebooks where required, the exception is a single equality condition
used to subset a Pandas Dataframe which I feel is a false-positive. Complaints about a couple of other variables but I can't see how to address those.
Sets
max-line-lengthto 120 forflake8viatox.ini..TopoStats Pull Requests