Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized Area thresholding #983

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AuroVarat
Copy link

This modification enhances the area thresholding function, significantly improving processing speed, especially for large images.

@ns-rse
Copy link
Collaborator

ns-rse commented Oct 25, 2024

Thanks for the Pull Request @AuroVarat I'll take a look through this on Monday.

In the mean time would you be able to address the failing tests please?

If you're not familiar with tests the software development section of our docs has some advice. You'll want to pip install -e .[dev,tests.docs] and ideally install the pre-commit hooks with pre-commit install. We use the pytest-testmon extension and so you'd have to run the tests once to check everything is working with pytest --testmon and then when you make commits only the tests that are affected will run.

Note also that pre-commit.ci has modified this branch by fixing some minor linting errors so you may want to git pull to get those changes (although if you install pre-commit locally it will make them before you can make your next commit again).

@AuroVarat
Copy link
Author

Hi, I am not familiar with tests but I managed to go through the steps and do the "pytest --testmon". It fails 8 tests, but it fails 8 tests regardless of my changes ( I did the same test by running it on the current main branch). Maybe I am doing something wrong, I will look at it when I have more time.

But if you see my changes, they are minimal and should not result in this failure. The code seems to be working fine when I am doing my analysis.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants