Skip to content

Commit

Permalink
Remove installation of maxdifussion as part of the dependency image b…
Browse files Browse the repository at this point in the history
…uild process (#107)
  • Loading branch information
parambole authored Sep 24, 2024
1 parent 3e3cdb8 commit 261f132
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 14 deletions.
5 changes: 1 addition & 4 deletions maxdiffusion_dependencies.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ ARG JAX_VERSION
ENV ENV_JAX_VERSION=$JAX_VERSION

# Set the working directory in the container
WORKDIR /deps
WORKDIR /app

# Copy all files from local workspace into docker container
COPY . .
Expand All @@ -54,8 +54,5 @@ RUN echo "Running command: bash setup.sh MODE=$ENV_MODE JAX_VERSION=$ENV_JAX_VER

RUN --mount=type=cache,target=/root/.cache/pip bash setup.sh MODE=${ENV_MODE} JAX_VERSION=${ENV_JAX_VERSION}

# Install MaxDiffusion
RUN pip install .

# Cleanup
RUN rm -rf /root/.cache/pip
9 changes: 3 additions & 6 deletions maxdiffusion_jax_stable_stack_tpu.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,16 @@ ARG COMMIT_HASH

ENV COMMIT_HASH=$COMMIT_HASH

RUN mkdir -p /deps
RUN mkdir -p /app

# Set the working directory in the container
WORKDIR /deps
WORKDIR /app

# Copy all files from local workspace into docker container
COPY . .

# Install Maxdiffusion jax stable stack requirements
RUN pip install -r /deps/requirements_with_jax_stable_stack.txt

# Install MaxDiffusion
RUN pip install .
RUN pip install -r /app/requirements_with_jax_stable_stack.txt

# Run the script available in JAX-Stable-Stack base image to generate the manifest file
RUN bash /jax-stable-stack/generate_manifest.sh PREFIX=maxdiffusion COMMIT_HASH=$COMMIT_HASH
6 changes: 2 additions & 4 deletions maxdiffusion_runner.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
ARG BASEIMAGE=maxdiffusion_base_image
FROM $BASEIMAGE

#FROM maxdiffusion_base_image

# Set the working directory in the container
WORKDIR /deps
WORKDIR /app

# Copy all files from local workspace into docker container
COPY . .

WORKDIR /deps
WORKDIR /app

0 comments on commit 261f132

Please sign in to comment.