fixes failing smoke tests #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aireenmei
previously approved these changes
Dec 4, 2024
README.md
Outdated
| @@ -188,7 +188,7 @@ MaxDiffusion started as a fork of [Diffusers](https://github.com/huggingface/dif | |||
|
|
|||
| Whether you are forking MaxDiffusion for your own needs or intending to contribute back to the community, a full suite of tests can be found in `tests` and `src/maxdiffusion/tests`. | |||
|
|
|||
| To run unit tests, simply run: | |||
| To run unit tests, you'll need to [install gcsfuse](https://cloud.google.com/storage/docs/cloud-storage-fuse/install) then simply run: | |||
There was a problem hiding this comment.
Do we recommend users to run setup.sh? It has gcsfuse installation: https://github.com/AI-Hypercomputer/maxdiffusion/blob/main/setup.sh#L28-L32. But I don't see it mentioned in README.md
There was a problem hiding this comment.
Oh that's a good idea. Let me try it first and make sure everything works as expected then I will update the README
There was a problem hiding this comment.
We already use it for github unit test: https://github.com/AI-Hypercomputer/maxdiffusion/blob/main/.github/workflows/UnitTests.yml#L43
There was a problem hiding this comment.
@aireenmei please take another look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some smoke tests that are failing.