Handle ENHSP-2020 returned plans as logs #137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output plan is not compliant with our current adaptor in the solver online, so we need to change it to parse it as a log file.
Relevant code that parses plan files returned a structured json file: https://github.com/AI-Planning/planning-as-a-service/blob/master/server/api/adaptor/planning_editor_adaptor/adaptor.py#L41
Otherwise, enhsp-2020 returns the following error:
usage: planutils [-h] {install,uninstall,run,remote,remote-list,check-installed,server,list,setup,upgrade,configure,show} ... planutils: error: unrecognized arguments: -o domain -f problem ', 'call': 'timeout 30 planutils run enhsp-2020 -o domain -f problem >> plan'
Test session for the editor: https://editor.planning.domains/#read_session=5FYdqT4OKG
Once this PR is merged, we need to update the check that the update in planutils propagates to docker, and the online server service.
In the future we may want to add a parser for temporal and numeric plans.