feat: Add more special tokens #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asafgardin
reviewed
Dec 28, 2023
asafgardin
reviewed
Dec 28, 2023
ai21_tokenizer/jurassic_tokenizer.py
Outdated
|
|
||
| self._newline_piece = config.get("newline_piece") | ||
| self.newline_id = self.convert_tokens_to_ids(self._newline_piece) |
There was a problem hiding this comment.
@tomeras91 I see that on line 48 we already have a newline_id whats the difference?
There was a problem hiding this comment.
You're right. I missed it. I'll just make it "public"
There was a problem hiding this comment.
Great. Also notice that another function encode is using it, so make sure you rename it in all places
etang-ai21
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add eos_id and newline_id