Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dask s2spy #176

Closed
wants to merge 5 commits into from
Closed

Allow dask s2spy #176

wants to merge 5 commits into from

Conversation

semvijverberg
Copy link
Member

  • Fixed issue test_correlation failing because of floating point level differences.
  • dask = "allowed" for both preprocess and rgdr apply_ufunc

geek-yang
geek-yang reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@geek-yang geek-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think it is nice to add dask to the list. But could you please fix the test and make all the checks green?

Besides, also see my comment in issue #177 , it seems the current implementation works well with timeseries which include some np.nan. Could you please double check your code? Or simply add a minimum example for me to reproduce the error?

Thanks @semvijverberg !

@ClaireDons ClaireDons mentioned this pull request Sep 25, 2024
Merged
@ClaireDons
Copy link
Contributor

We continued from this branch and made some changes so that the tests passed in #181, s2spy should now allow dask.

@ClaireDons ClaireDons closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geek-yang geek-yang geek-yang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@semvijverberg @ClaireDons @geek-yang