Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topic_transport: fix pruning bug in depacketizer #18

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

xqms
Copy link
Member

@xqms xqms commented Aug 13, 2021

Prune first, insert new message afterwards. Should fix #17.

This could potentially trigger a segfault when all messages are older
than 5s.

Maybe related: #17
@xqms xqms changed the base branch from master to develop August 13, 2021 10:43
@xqms
Copy link
Member Author

xqms commented Aug 20, 2021

@ros-pull-request-builder retest this please

1 similar comment
@xqms
Copy link
Member Author

xqms commented Nov 4, 2021

@ros-pull-request-builder retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receiver node from "develop" branch dies due to accessing nullptr
1 participant