Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing simulation status codes #2560

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 23, 2024

Closes #2559.

@dweindl dweindl requested a review from a team as a code owner October 23, 2024 08:32
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.76%. Comparing base (638c3ee) to head (35020e0).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2560   +/-   ##
========================================
  Coverage    77.76%   77.76%           
========================================
  Files          325      325           
  Lines        21858    21858           
  Branches      1473     1473           
========================================
  Hits         16997    16997           
  Misses        4834     4834           
  Partials        27       27           
Flag Coverage Δ
cpp 73.63% <ø> (ø)
cpp_python 34.20% <ø> (ø)
petab 37.07% <ø> (ø)
python 72.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/amici.cpp 79.16% <ø> (ø)
src/solver_cvodes.cpp 70.76% <ø> (ø)

@dweindl dweindl merged commit a20447a into AMICI-dev:develop Oct 23, 2024
18 of 20 checks passed
@dweindl dweindl deleted the fix_2559_status branch October 23, 2024 17:08
@dweindl dweindl linked an issue Oct 24, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing simulation status codes
2 participants