Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmark collection gradient check #2564

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 23, 2024

  • Fix instance vs class attribute for step sizes
  • Only flatten problems where necessary

* Fix instance vs class attribute for step sizes
* Only flatten problems where necessary
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.74%. Comparing base (a20447a) to head (aca37a7).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2564      +/-   ##
===========================================
- Coverage    77.76%   77.74%   -0.02%     
===========================================
  Files          325      325              
  Lines        21858    21857       -1     
  Branches      1473     1473              
===========================================
- Hits         16997    16993       -4     
- Misses        4834     4837       +3     
  Partials        27       27              
Flag Coverage Δ
cpp 73.62% <ø> (-0.02%) ⬇️
cpp_python 34.20% <ø> (-0.01%) ⬇️
petab 37.07% <ø> (-0.01%) ⬇️
python 72.40% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@dweindl dweindl self-assigned this Oct 23, 2024
@dweindl dweindl marked this pull request as ready for review October 24, 2024 11:53
@dweindl dweindl requested a review from a team as a code owner October 24, 2024 11:53
@dweindl dweindl merged commit 56e6956 into AMICI-dev:develop Oct 24, 2024
19 of 20 checks passed
@dweindl dweindl deleted the fix_grad_check branch November 11, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants