Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the agent redistribution stable if agent.fast = false. #89

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Nov 12, 2024

This also changes the default value of agent.fast to false. Using the inputs_random_ca file, I now get identical output.dat files between consecutive runs with the same random seed.

On my workstation GPU, the time goes up by about 7 seconds on a 4 minute simulation using this option.

@@ -189,6 +189,8 @@ void runAgent ()
mask_behavior.setVal(1);

AgentContainer pc(geom, dm, ba, params.num_diseases, params.disease_names, params.fast);
bool stable_redistribute = !params.fast;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Just a note: params.fast only matters when the n^2 interactions models are used, because it only affects changes the binning.

Copy link
Member Author

@atmyers atmyers Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also seems to be used in initialization when setting initial cases.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, there is binning there too.

@tannguyen153
Copy link
Collaborator

It ran pretty fast on Perlmutter. And the results didn't change run from run

@atmyers atmyers merged commit 81241f5 into development Nov 13, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants