CMake: dowstream projects must enable Fortran if AMReX_FORTRAN=ON #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
reviewed
Dec 22, 2020
| @@ -32,9 +32,6 @@ if (CMAKE_Fortran_COMPILER_LOADED) | |||
| INTERFACE_INCLUDE_DIRECTORIES | |||
| $<BUILD_INTERFACE:${PROJECT_BINARY_DIR}/mod_files> | |||
| ) | |||
| # adding those is a work-around that avoids that downstream C++ projects have | |||
| # to `enable_language(Fortran)` | |||
| target_link_libraries(amrex PUBLIC ${CMAKE_Fortran_IMPLICIT_LINK_LIBRARIES}) | |||
There was a problem hiding this comment.
Note: this served us reasonably well but did not cover all bases, e.g. we saw issues on macOS with Fortran functionality, OpenMP and LLVM+GFortran mixes (did use the LLVM OpenMP libs but add libgfortran unconditionally) as well as issues with Windows' MSVC + CUDA #1585
Generally, the calling project must enable_language(Fortran) in CMake. Languages are not encapsulated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note: this also changes the default of
AMReX_FORTRANtoOFF.Additional background
Checklist
The proposed changes: