Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Mixed Precision Particle Tests #3162

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

CI: Mixed Precision Particle Tests #3162

wants to merge 1 commit into from
+1 −0

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Feb 16, 2023 •
edited
Loading

Summary

Adds a CI test that runs particle tests with single precision, but fields with default (double).

Additional background

We saw some the Particles_NeighborParticles_MPI and Particles_GhostsAndVirtuals tests fail with precision issues elsewhere #2878 .

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@ax3l ax3l added the test label Feb 16, 2023
@ax3l ax3l requested a review from atmyers February 16, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmyers atmyers Awaiting requested review from atmyers

At least 1 approving review is required to merge this pull request.

Assignees

@atmyers atmyers

Labels
help wanted test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ax3l @atmyers