Fix dangling-reference warnings for particle functions. #4241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With gcc 13.2 and all warnings/errors turned on, some particle functions generate a dangling-reference error.
This PR fixes those errors.
Additional background
To reproduce, in
Tests/Particles/ParticleMesh/main.cpp
add lines 149-150:and in
Tests/Particles/ParticleMesh/GNUmakefile
add a final line:
Similar lines in:
./Src/Extern/SENSEI/AMReX_ParticleDataAdaptorI.H
may also have the same error, but I don't have SENSEI installed to check.
Checklist
The proposed changes: