Add FitRWMWaveform to Unity + Factory #326
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
In PR #289 I forgot to add the tool to Factory + Unity. We noticed in the
PrintDQ
tool that we were getting 0% of events with a BRF fit - i suspect its because theFitRWMWaveform
tool was never compiled / built.Checklist before submitting your PR
new
usage, there is a reason the data must be on the heapnew
there is adelete
, unless I explicitly know why (e.g. ROOT or a BoostStore takes ownership)Additional Material
PrintDQ
toolchain where we noticed there was a 0% fit rate: https://github.com/ANNIEsoft/ToolAnalysis/tree/Application/configfiles/PrintDQ