Skip to content

Commit

Permalink
Update TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
forgottosave committed Oct 29, 2024
1 parent 1cfa0ab commit 4ea68e2
Showing 1 changed file with 11 additions and 26 deletions.
37 changes: 11 additions & 26 deletions src/core/OSTreeTUI.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -137,33 +137,18 @@ int OSTreeTUI::main(const std::string& repo, const std::vector<std::string>& sta
});

// COMMIT TREE
/* TODO - The commit-tree is currentrly under a heavy rebuild, see implementation To-Dos below.
* For a general list of To-Dos refer to https://github.com/AP-Sensing/ostree-tui/pull/21
*
* > Component commitTree should be a Stacked(...) to allow for snappy windows to be arranged with
* a drag & drop funcitonality.
* > Snappy Windows should be an abstracted element, similar to windows, but snapping back to their
* place after being dropped.
* > While dragging a window, the branches should be greyed out, only coloring the branch that the
* mouse dragging a commit hovers over
* * switch to drag-mode when commit is taken
* * let mouse event through to branches
* * if commit is dropped on branch, start promotion dialogue
* > There should obviously still be a commit tree on the left side. How the exact implementation
* would go is still to be figured out. It this would be one, or many different elements mainly
* depends on how the overlap detection with branches would work, when dragging commits.
*/
/* TODO The commit-tree is currentrly under a heavy rebuild, see implementation To-Dos below.
* For a general list of To-Dos refer to https://github.com/AP-Sensing/ostree-tui/pull/21
*
* TODO remove info, that doesn't need to be shared
* TODO extend with keyboard functionality:
* if 'p' is pressed: start promotion
* TODO add commit deletion
* add deletion button & ask for confirmation (also add keyboard functionality)
* TODO maybe re-arrange the manager window to remove the tabs again
* now that promotion and deletion is gone / changed, we have enough rooom to fit both the info and the filter
*/
// commit promotion state
// shared with all relevant components to monitor and react to
// TODO maybe create separate struct, or class (especially if more info comes, not to pass
// everything separately)
// could also be applied to whole OSTreeTUI -> new class holding all states
// TODO maybe pass the window a reference to the cpplibostree repo, so it can start the promotion
// TODO extend with keyboard functionality:
// if 'p' is pressed: start promotion
// TODO remove promotion window
// TODO maybe re-arrange the manager window to remove the tabs again
// now that promotion and deletion is gone / changed, we have enough rooom to fit both the info and the filter
bool inPromotionSelection{false};
std::string promotionHash{""};
std::string promotionBranch{""};
Expand Down

0 comments on commit 4ea68e2

Please sign in to comment.