Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI #19

Merged
merged 12 commits into from
Oct 17, 2024
Merged

Add CI #19

merged 12 commits into from
Oct 17, 2024

Conversation

forgottosave
Copy link
Collaborator

@forgottosave forgottosave commented Oct 15, 2024

Defines a Github CI, with the following requirements (see Issue #18):

  • Add a CI run that builds using gcc as compiler a debug build
  • Add a CI run that builds using gcc as compiler a release build
  • Add a CI run that builds using clang as compiler a debug build
  • Add a CI run that builds using clang as compiler a release build
  • Run a clang-tidy build in debug
  • Run a clang-format check
  • All CI runs have to be run under fedora:latest
  • Add cppcheck
  • Investigate if CI builds using sanitizers make sense e.g. thread-, address-, undefined behaviour-, ...

Define a Gihub CI, that builds the project in a fedora container
@forgottosave forgottosave self-assigned this Oct 15, 2024
@forgottosave forgottosave marked this pull request as draft October 15, 2024 08:42
@forgottosave forgottosave added state: 👷🏻 in development Currently worked on priority: ☝️ high 🧱 CI CI run related (bug, new feature,...) labels Oct 15, 2024
@forgottosave
Copy link
Collaborator Author

forgottosave commented Oct 16, 2024

On the sanitizers: I don't see why they would hurt at the moment, so I integrated them as well.
Example runs of the latest CI can be found here

@forgottosave forgottosave marked this pull request as ready for review October 16, 2024 09:09
@forgottosave forgottosave requested a review from COM8 October 16, 2024 09:10
@forgottosave forgottosave added state: 👁️ review Ready for review and removed state: 👷🏻 in development Currently worked on labels Oct 16, 2024
Copy link
Member

@COM8 COM8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Found a few minor things.

.github/workflows/cmake-multi-platform.yml Show resolved Hide resolved
.github/workflows/cmake-multi-platform.yml Outdated Show resolved Hide resolved
.github/workflows/cmake-multi-platform.yml Outdated Show resolved Hide resolved
.github/workflows/cmake-multi-platform.yml Outdated Show resolved Hide resolved
.github/workflows/cmake-multi-platform.yml Outdated Show resolved Hide resolved
.github/workflows/cmake-multi-platform.yml Outdated Show resolved Hide resolved
.github/workflows/cmake-multi-platform.yml Outdated Show resolved Hide resolved
can be re-added if new containers are added
should be re-added later on, when tests are integrated into this project
@COM8 COM8 linked an issue Oct 16, 2024 that may be closed by this pull request
9 tasks
@forgottosave forgottosave mentioned this pull request Oct 16, 2024
4 tasks
@forgottosave forgottosave force-pushed the main branch 2 times, most recently from 0e3e031 to 01ae60b Compare October 17, 2024 06:05
@forgottosave forgottosave force-pushed the main branch 5 times, most recently from 8dcac34 to 65e1972 Compare October 17, 2024 06:17
by replacing it with a pre-defined cppcheck-action
Copy link
Member

@COM8 COM8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Looks good!

@forgottosave forgottosave merged commit ca1e134 into AP-Sensing:main Oct 17, 2024
@forgottosave forgottosave added state: ✅ done Finished & Reviewed and removed state: 👁️ review Ready for review labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧱 CI CI run related (bug, new feature,...) priority: ☝️ high state: ✅ done Finished & Reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI Runs
2 participants