Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAuthabielf64] Define NT-ARM-PAUTH-ABI-tag #235

Closed
wants to merge 1 commit into from

Conversation

smithp35
Copy link
Contributor

Be more explicit about the fields of the SHT_NOTE section and define a symbolic constant for the value 1.

#234

Be more explicit about the fields of the SHT_NOTE section and
define a symbolic constant for the value 1.

ARM-software#234
@smithp35
Copy link
Contributor Author

I will submit a follow up patch to bring the PAuthABI in line with the recent build attributes and GNU properties pull requests. Likely early next year as I'll be away for 3 weeks starting on Monday 18th.

Essentially:
The Alternative .note.GNU.property will become the recommended ELF marking, and the note section will become the alternative.

@smithp35
Copy link
Contributor Author

This pull request is no longer required as it was included in #240

The name field (``namesz`` / ``name``) contains the string "ARM". The
type field shall be 1, and the ``descsz`` field must be at least 16.
The first 16 bytes of the description must contain 2 64-bit words, with
The ``namesz`` field shall be 4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall be -> is


The ``descsz`` field must be at least 16. See ``desc`` below.

The type field shall be ``NT_ARM_TYPE_PAUTH_ABI_TAG``, defined to the

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall be -> is

The type field shall be ``NT_ARM_TYPE_PAUTH_ABI_TAG``, defined to the
value 1.

The ``name`` field shall be the null-terminated string ``ARM``.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall be -> is

Copy link

@sallyarmneale sallyarmneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor phrasing changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants