-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to C11, and use char16_t for UTF-16 strings #1010
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Peter Collingbourne <[email protected]>
I have been considering adding support for LLVM Embedded Toolchain for Arm, but this will require some changes to project-generator. |
Interesting, I wasn't aware of that project. I was just building LLVM directly and using musl as the libc, which justifiably rejected my patch to add But either way this seems like a good change to make in order to avoid depending on a build flag which the musl developers correctly describe as being fundamentally incompatible with libc. What do you think?
|
Signed-off-by: Peter Collingbourne <[email protected]>
This is no longer necessary now that we no longer use wchar_t. Signed-off-by: Peter Collingbourne <[email protected]>
This change does not work with |
armcc is ARM Compiler 5, right? I noticed that the mbed OS project has dropped support for it: https://os.mbed.com/blog/entry/Removal-of-ARM-Compiler-5-and-uARM-toolc/ Have you considered following suit in DAPLink? |
Yes we have decided to also move from
|
The use of
wchar_t
with-fshort-wchar
to get UTF-16 strings is non-standard and can lead to porting issues. So let's switch tochar16_t
, which also requires switching the project to build with C11.This all builds in my WIP fork of DAPLink that targets upstream LLVM/Clang/LLD. I haven't been able to try this in any of the officially supported compilers yet, I'm mostly just guessing at the required build file updates.