-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Cypress devices #601
base: main
Are you sure you want to change the base?
Conversation
@p2k000 Can you please rebase onto master? You might want to squash down to 1 or 2 commits. You will need to force push. The recent changes to add the K26F HIC are showing up in this PR, which greatly increases the number of changed files. This is also why Thanks! Btw, we prefer to not have merges to/from master or other branches in pull requests. This keeps the git history much cleaner. |
@p2k000 Would you mind rebasing and squashing? We need to remove the merge commits to have a clean commit history. You will need to force push after you rebase. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments for requested changes. Also need to rebase on top of #612 once that is merged. And please squash to a single commit when you rebase.
Fyi, #612 has been merged now. You can now rebase on top of master and remove the target-specific changes to common code in this PR. |
97d23fc
to
309d181
Compare
309d181
to
61f0fc7
Compare
Please rebase again. Shall we proceed with this PR? what is the status here after the last review |
@0xc0170, I will be ready to publish all modified sources on WW1940. At the moment, almost all comments are resolved. |
61f0fc7
to
d6f5d87
Compare
@MarianSavchuk I merged one of your PRs, reviewing others. This will need a rebase (and its ready for final review?). let me know |
d6f5d87
to
050c668
Compare
/morph test |
This comment has been minimized.
This comment has been minimized.
1 similar comment
/morph test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest looks to be target related, will review later today hopefully.
/morph test |
1 similar comment
/morph test |
Build errors reported, please review |
will this happen? @MarianSavchuk please consider adding psoc4 as well |
b0a0783
to
acd2c9f
Compare
acd2c9f
to
eb43264
Compare
Hi @nimish @MarianSavchuk, I failed to notice this PR was still active. Could you rebase and add the startup for GCC ARM? |
No description provided.