Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/soa #37

Merged
merged 312 commits into from
Mar 22, 2024
Merged

Features/soa #37

merged 312 commits into from
Mar 22, 2024

Conversation

MarleneBusch
Copy link
Collaborator

This pull request introduces a revised kinematic module, a new package structure and a h5 files from which data is loaded.
(Struct of Array has not been implemented.)

kalebphipps and others added 30 commits March 14, 2024 13:20
@kalebphipps
add test_data
5ce129c
@MarleneBusch
rewrite rigid body module
0414d8c
@kalebphipps
add test_data
fb84c06
@kalebphipps
remove old rotation functions
481d6a7
@kalebphipps
add rotate_nu
df3b3ef
@MarleneBusch
clean up kinematic, kinematic test works
e4eb799
@kalebphipps
include offset in scenario
1d22139
@kalebphipps
fix sin convention
1cba5ae
@kalebphipps
debugging - still not working
a6c5b6d
@kalebphipps
more debugging, still not working
b937db5
@kalebphipps
new rotation matrix for sun, still not working
c422b5a
@kalebphipps
update h5 offset and test rotation sign
5eb6834
@kalebphipps
fix 4d representation - it almost works!
91275a6
@kalebphipps
fix 4d representation - it almost works!
9abc3f1
@MarleneBusch
norm
2835eb0
@MarleneBusch
Merge branch 'features/soa' of https://github.com/ARTIST-Association/…
72e2df6 
…ARTIST into features/soa
@kalebphipps
debugging - still not working
2eceb5b
@kalebphipps
debugging - still not working
7bdec32
@MarleneBusch
Merge branch 'features/soa' of https://github.com/ARTIST-Association/…
975fdf2 
…ARTIST into features/soa
@MarleneBusch
alignemnt not working
81571c8
@kalebphipps
more debugging
992c798
@kalebphipps
change offset
0e1e4ad
@kalebphipps
update alignment
d667663
@kalebphipps
refactor
2e89043
@kalebphipps
clean up and fix
5450a21
@kalebphipps
clean up code
35042fc
@MarleneBusch
clean up the code
e23e6dc
@MarleneBusch
change Docstrings
c08cbed
@MarleneBusch
add inits, docstrings, type hints
482dea1
@MarleneBusch
delete comment
845b2cb
MarleneBusch and others added 18 commits March 22, 2024 13:40
@MarleneBusch @mcw92
Docstrings
561e5d2 
Co-authored-by: Marie Weiel <[email protected]>
@MarleneBusch @mcw92
Update artist/util/scenario_generator.py
e5d2721 
Co-authored-by: Marie Weiel <[email protected]>
@MarleneBusch @mcw92
Docstrings
656930b 
Co-authored-by: Marie Weiel <[email protected]>
@MarleneBusch @mcw92
type hints
8f4f826 
Co-authored-by: Marie Weiel <[email protected]>
@MarleneBusch @mcw92
Docstrings
99fdae1 
Co-authored-by: Marie Weiel <[email protected]>
@MarleneBusch @mcw92
type hints
e9e7db5 
Co-authored-by: Marie Weiel <[email protected]>
@MarleneBusch @mcw92
Docstrings
1694796 
Co-authored-by: Marie Weiel <[email protected]>
@MarleneBusch @mcw92
Docstrings
4b01f4b 
Co-authored-by: Marie Weiel <[email protected]>
@MarleneBusch @mcw92
type hints
e4284ae 
Co-authored-by: Marie Weiel <[email protected]>
@MarleneBusch @mcw92
Docstrings
fc7569f 
Co-authored-by: Marie Weiel <[email protected]>
@MarleneBusch @mcw92
type hints
2f3c3eb 
Co-authored-by: Marie Weiel <[email protected]>
@MarleneBusch @mcw92
Docstrings
65478cb 
Co-authored-by: Marie Weiel <[email protected]>
@MarleneBusch @mcw92
type hints
b7c7cf7 
Co-authored-by: Marie Weiel <[email protected]>
@MarleneBusch @mcw92
fix typo
8326af9 
Co-authored-by: Marie Weiel <[email protected]>
@MarleneBusch @mcw92
Docstrings
f57632b 
Co-authored-by: Marie Weiel <[email protected]>
@MarleneBusch @mcw92
Docstrings
0276933 
Co-authored-by: Marie Weiel <[email protected]>
@kalebphipps
include comment for private method
6e4d10f
@kalebphipps
remove abstract clase AModule
85f2142
@kalebphipps kalebphipps requested a review from mcw92 March 22, 2024 13:08
mcw92
mcw92 approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@mcw92 mcw92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the last two comments.

artist/physics_objects/alignment.py Outdated Show resolved Hide resolved
artist/physics_objects/concentrator.py Outdated Show resolved Hide resolved
artist/physics_objects/heliostat.py Outdated Show resolved Hide resolved
artist/physics_objects/heliostat.py Outdated Show resolved Hide resolved
artist/physics_objects/heliostat.py Outdated Show resolved Hide resolved
artist/physics_objects/kinematic.py Outdated Show resolved Hide resolved
MarleneBusch and others added 7 commits March 22, 2024 14:27
@MarleneBusch @mcw92
remove AModule reference
df08e7d 
Co-authored-by: Marie Weiel <[email protected]>
@MarleneBusch @mcw92
remove AModule reference
2affbc7 
Co-authored-by: Marie Weiel <[email protected]>
@MarleneBusch @mcw92
remove AModule reference
cc46ce8 
Co-authored-by: Marie Weiel <[email protected]>
@MarleneBusch @mcw92
Docstrings
0467646 
Co-authored-by: Marie Weiel <[email protected]>
@MarleneBusch @mcw92
Docstrings
f020cba 
Co-authored-by: Marie Weiel <[email protected]>
@MarleneBusch @mcw92
remove AModule reference
588e0a1 
Co-authored-by: Marie Weiel <[email protected]>
@kalebphipps
update docstrings
1c9c5be
@kalebphipps kalebphipps merged commit b9b5568 into main Mar 22, 2024
5 checks passed
@kalebphipps kalebphipps deleted the features/soa branch June 7, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcw92 mcw92 mcw92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@MarleneBusch @mcw92 @kalebphipps