Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an OPERA RGB workflow #221

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Create an OPERA RGB workflow #221

wants to merge 7 commits into from

Conversation

forrestfwilliams
Copy link
Contributor

@forrestfwilliams forrestfwilliams commented Jan 17, 2024 •
edited
Loading

After installing asf-tools try running:

opera_rgb OPERA_L2_RTC-S1_T121-257997-IW1_20240106T234116Z_20240108T110037Z_S1A_30_v1.0

@forrestfwilliams forrestfwilliams requested a review from a team as a code owner January 17, 2024 16:01
jhkennedy
jhkennedy reviewed Jan 17, 2024
View reviewed changes
src/asf_tools/opera_rgb.py Outdated
Comment on lines 12 to 13
BROWSE_IMAGE_MIN_PERCENTILE = 3
BROWSE_IMAGE_MAX_PERCENTILE = 97
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd make more sense to make these arguments to normalize_browse_image_band with default values than hard coded constants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhkennedy jhkennedy jhkennedy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forrestfwilliams @jhkennedy