Fix wording #89
Merged
Fix wording #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximiliankolb
commented
Dec 5, 2024
| @@ -35,7 +35,7 @@ const ResourceQuotaEmptyState = () => { | |||
| iconType="pf" | |||
| header={__('Resource Quotas')} | |||
| description={__( | |||
| 'Resource Quotas help admins to manage hardware resources (like CPUs, RAM, and disk space) among users or usergroups. \n\rDefine a Resource Quota here and apply it to users in order to guarantee a free share of your resources.' | |||
| 'Resource Quotas help admins to manage hardware resources including CPUs, memory, and disk space among users or usergroups. \n\rDefine a Resource Quota here and apply it to users in order to guarantee a free share of your resources.' | |||
There was a problem hiding this comment.
After we have merged theforeman/foreman-documentation#3460, we could also add a link to the official Foreman docs. Thorben and I have already implemented something similar in foreman_remote_execution. I believe there is a shared function that we can use which handles the logic so we'll only have to provide the name of the guide and the anchor.
Thorben-D
approved these changes
Dec 6, 2024
|
Thanks @maximiliankolb and @Thorben-D! 🐧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit by commit.