Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github-actions to dependabot #95

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

dosas
Copy link
Contributor

@dosas dosas commented Dec 11, 2024

No description provided.

@dosas dosas requested a review from bastian-src December 11, 2024 07:41
@bastian-src
Copy link
Contributor

bastian-src commented Dec 11, 2024

Good catch, would be nice to trigger the CI weekly!

However, how does this work with path-dependent GitHub actions? AFAIK we trigger JS tests only if file in the webpack folder changes in a PR.

@dosas
Copy link
Contributor Author

dosas commented Dec 12, 2024

However, how does this work with path-dependent GitHub actions? AFAIK we trigger JS tests only if file in the webpack folder changes in a PR.

good point: Thinking about this shortly, there are two possibilities that come to my mind:

  • add .gemspec file to the js path dependency (which is weird and only covers this special case)
  • drop the path dependency and run always run the js tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants