Improve date parsing #167
Merged
Improve date parsing #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
QinHaichen12
reviewed
Nov 8, 2024
| } | ||
| // Fix month case issue | ||
| month = month.substring(0, 1).toUpperCase() + month.substring(1).toLowerCase(); | ||
| // Nothing can be done about year errors due to ambiguity |
| assertFalse(SessionDate.isValidDate("30 Mar 024")); // invalid year | ||
| assertFalse(SessionDate.isValidDate(" Mar 2024")); // missing day | ||
| assertFalse(SessionDate.isValidDate("29 2024")); // missing month | ||
| assertFalse(SessionDate.isValidDate("30 Mar ")); // missing year | ||
|
|
There was a problem hiding this comment.
should there be test cass for invalid dates such as 40 sep 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.