Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check commands for bugs and add tests #236

Conversation

starchypotatocode
Copy link

@starchypotatocode starchypotatocode commented Nov 11, 2024

Commit 1: Remove dead code with unused lines, does not affect user-facing behaviour.
Commit 2: Add tests to command parsers.
Commit 3: Add final tests to commands.
Commit 4: Checkstyle.
Commit 5: Merge from master.
Commit 6: Checkstyle, again.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
...hallpointer/address/model/session/SessionDate.java 100.00% <100.00%> (ø) 11.00 <0.00> (ø)
...r/address/storage/JsonSerializableHallPointer.java 93.75% <100.00%> (ø) 4.00 <0.00> (ø)

... and 3 files with indirect coverage changes

@starchypotatocode starchypotatocode merged commit 56cb9d4 into AY2425S1-CS2103T-W14-3:master Nov 11, 2024
4 checks passed
@starchypotatocode starchypotatocode deleted the branch-check-commands branch December 1, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant