Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Example Makefile to build on OSX and Linux #136

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

garyo
Copy link
Contributor

@garyo garyo commented Dec 7, 2023

Also use linux, proper modern preprocessor symbol.

Closes #117.

Also use __linux__, proper modern preprocessor symbol.

Signed-off-by: Gary Oberbrunner <[email protected]>
@garyo garyo requested a review from barretpj December 7, 2023 20:37
@garyo garyo self-assigned this Dec 7, 2023
@garyo
Copy link
Contributor Author

garyo commented Dec 7, 2023

Tested on OSX and Linux. Note that I also specify C++11 in the Makefile because some of the example sources use brace initializers.

Copy link
Contributor

@barretpj barretpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garyo garyo merged commit 50b87f5 into main Jan 29, 2024
8 checks passed
@garyo garyo deleted the fix-examples-117 branch February 24, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples don't compile
2 participants