Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenCL Image support to the updated GPU rendering extension: #140

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

SonyDennisAdams
Copy link
Contributor

  • Modify ofxGPURender.h to support OpenCL Images
  • Add kOfxImageEffectActionBeginSequenceRender and kOfxImageEffectActionEndSequenceRender as required actions for some CUDA/Metal/OpenCL properties where they were not listed
  • Also make documentation edits in the same header
  • Modify GPUGain example to also support OpenCL Images and show how to disambiguate in the case where a plug-in supports both OpenCL Buffers and OpenCL Images

* Modify ofxGPURender.h to support OpenCL Images
* Add kOfxImageEffectActionBeginSequenceRender and kOfxImageEffectActionEndSequenceRender as required actions for some CUDA/Metal/OpenCL properties where they were not listed
* Also make documentation edits in the same header
* Modify GPUGain example to also support OpenCL Images and show how to disambiguate in the case where a plug-in supports both OpenCL Buffers and OpenCL Images

Signed-off-by: Dennis Adams <[email protected]>
@garyo garyo mentioned this pull request Feb 11, 2024
@fxtech
Copy link
Contributor

fxtech commented Feb 11, 2024

When I tried to build MacOS on the gpu-gain-example branch I get this error:

CMake Error at CMakeLists.txt:51 (find_package):
  By not providing "Findopengl_system.cmake" in CMAKE_MODULE_PATH this
  project has asked CMake to find a package configuration file provided by
  "opengl_system", but CMake did not find one.

  Could not find a package configuration file provided by "opengl_system"
  with any of the following names:

    opengl_systemConfig.cmake
    opengl_system-config.cmake

  Add the installation prefix of "opengl_system" to CMAKE_PREFIX_PATH or set
  "opengl_system_DIR" to a directory containing one of the above files.  If
  "opengl_system" provides a separate development package or SDK, be sure it
  has been installed.

@revisionfx
Copy link
Contributor

Would it be possible to add a property that states if the OpenCL Image is backed by an OpenGL texture?
There is one host for example that supports OpenCL but not OpenGL...
Also can a plugin report based on parameter state it does not support OpenCL now just OpenGL... ?

Copy link
Contributor

@garyo garyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garyo garyo merged commit e18fd49 into gpu-gain-example Feb 24, 2024
9 checks passed
@garyo garyo deleted the gpu-gain-opencl-images branch February 24, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants