-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced Anisotropic Surfacing Kernels and PCA methods #1634
base: master
Are you sure you want to change the base?
Introduced Anisotropic Surfacing Kernels and PCA methods #1634
Conversation
Idclip
commented
Jul 4, 2023
•
edited
Loading
edited
6435a72
to
138a872
Compare
38380c4
to
5b26645
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned, please remove templated interrupter from all of these API methods.
/// @param interrupt An optional interrupter. | ||
template <typename PointDataGridT, | ||
typename FilterT = NullFilter, | ||
typename InterrupterT = util::NullInterrupter> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer if we don't add new methods with interrupter template arguments as it complicates explicit template instantiation. All the Houdini SOPs now use HoudiniInterrupter which sub-classes util::NullInterrupter, so fine to just provide util::NullInterrupter as an un-templated argument.
mWeightedPositions[id] += Psrc * weight; // @note: world space position is weighted | ||
#else | ||
// @warning much slower than accessing the buffers directly | ||
mWeights->set(id, mWeights->get(id) + weight); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the setUnsafe()
and getUnsafe()
methods resolve the performance issues or is there something else you gain (simd?) from going directly to the buffers?
5b26645
to
de71777
Compare
Signed-off-by: Nick Avramoussis <[email protected]>
Signed-off-by: Nick Avramoussis <[email protected]>
… PointRasterize and other fixes Signed-off-by: Nick Avramoussis <[email protected]>
…y zero Signed-off-by: Nick Avramoussis <[email protected]>
Signed-off-by: Nick Avramoussis <[email protected]>
…ys activate the correct topology if the search radius was larger than the point radius Signed-off-by: Nick Avramoussis <[email protected]>
…r non-anisotropic neighbourhoods on the PCA methods Signed-off-by: Nick Avramoussis <[email protected]>
…ps rasterizer wouldn't be found by point transfer Signed-off-by: Nick Avramoussis <[email protected]>
faf1b1c
to
7f8b438
Compare