Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nullptr dereferences found by gcc 11.4 #1679

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix nullptr dereferences found by gcc 11.4 #1679

merged 1 commit into from
Oct 17, 2023

Conversation

e4lam
Copy link
Contributor

@e4lam e4lam commented Oct 10, 2023

I'm not sure if we can actually hit these code paths in practice but this at least shuts up the warnings.

@e4lam e4lam requested a review from kmuseth as a code owner October 10, 2023 15:23
jmlait
jmlait approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@jmlait jmlait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might become more important when we have adaptive grids...

@Idclip Idclip merged commit 97b94f1 into AcademySoftwareFoundation:master Oct 17, 2023
10 checks passed
@jmlait jmlait deleted the nullptr_fix branch October 17, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danrbailey danrbailey danrbailey approved these changes

@jmlait jmlait jmlait approved these changes

@kmuseth kmuseth Awaiting requested review from kmuseth kmuseth is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@e4lam @jmlait @danrbailey @Idclip