Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SPDX license identifiers to files missing them #1986

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Added SPDX license identifiers to files missing them #1986

merged 1 commit into from
Dec 17, 2024

Conversation

swahtz
Copy link
Contributor

@swahtz swahtz commented Dec 17, 2024

No description provided.

@swahtz swahtz requested a review from dgovil December 17, 2024 02:23
@swahtz swahtz mentioned this pull request Dec 17, 2024
Draft
@swahtz swahtz enabled auto-merge December 17, 2024 19:22
apradhana
apradhana reviewed Dec 17, 2024
View reviewed changes
nanovdb/nanovdb/python/test/TestNanoVDB.py
@@ -1,4 +1,6 @@
# /usr/bin/env python
#!/usr/bin/env python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swahtz , @matthewdcong : is the first line necessary for this python script? Can we get rid of it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's necessary if someone wants to run it directly ./TestnanoVDB.py.
Also minor nit, it might be good to use python3 instead of just python

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks for the clarification @dgovil.

@swahtz swahtz merged commit 74c3e68 into master Dec 17, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apradhana apradhana apradhana approved these changes

@dgovil dgovil dgovil approved these changes

@kmuseth kmuseth Awaiting requested review from kmuseth kmuseth is a code owner

@jmlait jmlait Awaiting requested review from jmlait jmlait is a code owner

@Idclip Idclip Awaiting requested review from Idclip Idclip is a code owner

@danrbailey danrbailey Awaiting requested review from danrbailey danrbailey is a code owner

@richhones richhones Awaiting requested review from richhones richhones is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swahtz @dgovil @apradhana