Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tell docs.rs to only build accesskit_windows on Windows #483

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

DataTriny
Copy link
Member

Currently, docs.rs fails to build accesskit_windows.

I tried documenting the crate on Linux and I get the same compilation errors. I think that this crate now only builds on Windows so we need to tell docs.rs about this. We might want to investigate why this breakage happened later, and if we still want this crate to build on non-Windows platforms.

During investigation, I found broken links in our common crate, I'll deal with them in another PR.

Copy link
Contributor

@mwcampbell mwcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mwcampbell mwcampbell merged commit 1fead29 into main Nov 23, 2024
9 checks passed
@mwcampbell mwcampbell deleted the fix-windows-docs branch November 23, 2024 14:20
@github-actions github-actions bot mentioned this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants