Run tray icon generation only when systray available. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I'm a bit concerned however about the UX for the users where a systray isn't available since it gives a differing experience (although that's better than not working at all, lol). Preferably we'd just implement support for appindicators as discussed in ActivityWatch/activitywatch#238 but this might be a good alternative for now. What do you think @johan-bjareholt? |
|
It now also seems like upstream gnome itself has removed support for appindicators as well. |
|
I've recently added a Kinda makes this PR redundant, so closing. Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got annoyed by this pop up error on POP_os 18.04.
Should happen on ubuntu > 17.04 or any gnome 3 distro.
Run code only when systray is available instead of showing an error.
Now I can run aw-qt on startup with no issues.