Kwin marked as not working #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have implemented it for Wayland + KDE, but I was already aware of the issue and planned the code with independent adapters in mind. |
|
@2e3s Is there any chance that your implementation can be merged into this repo? |
|
@cjc7373 not really, my code is not based on this repository at all, so there is nothing to merge. Also this is "aw-watcher-window-wayland" while I intended to cover all Linux which includes X11, and later other platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kwin, the KDE window manager and Wayland compositor, clearly does not work with this watcher when using it over Wayland. Further testing should be done to figure out more, I do not have the expertise required to figure out why, but it appears that Kwin does not support any of the protocols specified. As mentioned by @renyuneyun in ActivityWatch/activitywatch#92 it is possible to get the active window from kwin, but a great deal more work would be required to make this happen. It may be a bit different than just adding another protocol though as this dose not seem to be just a protocol that would be required.