forked from AdaGold/dynamic-programming
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M. Nguyen - Dynamic Programming #29
Open
melissa-nguyen
wants to merge
1
commit into
Ada-C15:master
Choose a base branch
from
melissa-nguyen:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"python.testing.pytestArgs": [ | ||
"tests" | ||
], | ||
"python.testing.unittestEnabled": false, | ||
"python.testing.pytestEnabled": true | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,4 +9,16 @@ def max_sub_array(nums): | |
return 0 | ||
if len(nums) == 0: | ||
return 0 | ||
pass | ||
|
||
# default both variables to the first index b/c the first index is the max value and max ending thus far | ||
max_so_far = nums[0] | ||
max_ending_here = nums[0] | ||
|
||
for i in range(1, len(nums)): | ||
|
||
max_ending_here = max(max_ending_here + nums[i], nums[i]) | ||
|
||
# continue updating value of variable as we itr | ||
max_so_far = max(max_so_far, max_ending_here) | ||
|
||
return max_so_far | ||
Comment on lines
+12
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 space/time complexity? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,4 +7,31 @@ def newman_conway(num): | |
Time Complexity: ? | ||
Space Complexity: ? | ||
""" | ||
Comment on lines
7
to
9
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 Space/time complexity? |
||
pass | ||
# <-------- NEWMAN CONWAY CONCEPT --------> | ||
# P(1) = 1 | ||
# P(2) = 1 | ||
# for all n > 2 | ||
# P(n) = P(P(n - 1)) + P(n - P(n - 1)) | ||
|
||
# base case -> if num is either 0 or 1 | ||
if num == 0: | ||
raise ValueError | ||
if num == 1: | ||
return '1' | ||
|
||
# P(1) = 1; P(2) = 1, P(3) = 2 | ||
sequence = [0, 1, 1] | ||
|
||
# initialize string with starting values | ||
# remamnining values will be appended to string | ||
newman_conway_str = "1 1 " | ||
|
||
# need to start range at index 3 | ||
for i in range(3, num + 1): | ||
# calculating next value to append | ||
sequence.append(sequence[sequence[i - 1]] + sequence[i - sequence[i - 1]]) | ||
|
||
# must convert to string | ||
newman_conway_str += f"{sequence[i]} " | ||
|
||
return newman_conway_str[:-1] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
.vscode
folder could be added to.gitignore