Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aeron - Rock #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Aeron - Rock #2

wants to merge 2 commits into from

Conversation

AeronRoemer
Copy link

Heaps Practice

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How is a Heap different from a Binary Search Tree?
Could you build a heap with linked nodes?
Why is adding a node to a heap an O(log n) operation?
Were the heap_up & heap_down methods useful? Why?

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Aeron, the Heapsort looks incomplete, but the rest looks very good.

Comment on lines +7 to +11
let heap = new MinHeap;

while(!heap.isEmpty()) {
list.push(heap.remove());
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems 1/2 completed?

Comment on lines +13 to 16
// Time Complexity: generally Log N
// Space Complexity: equal to the nodes in the heap - 1

add(key, value = key) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines 27 to 29
// Time Complexity: ?
// Space Complexity: ?
remove() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines 61 to 63
// Time complexity: ?
// Space complexity: ?
heapUp(index) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Time/space complexity.

if (parentIndex > 0) {
this.heapUp(parentIndex)
}
}
}

// This helper method takes an index and
// moves it up the heap if it's smaller
// than it's parent node.
heapDown(index) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants