Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C15-Paper-Weishan #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions heaps/heap_sort.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,19 @@
from heaps.min_heap import MinHeap


def heap_sort(list):
""" This method uses a heap to sort an array.
Time Complexity: ?
Space Complexity: ?
Time Complexity: O(nlogn)
Space Complexity: O(n)
Comment on lines 4 to +7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

"""
pass
heap = MinHeap()

for item in list:
heap.add(item)

i = 0
while not heap.empty():
list[i] = heap.remove()
i += 1

return list
59 changes: 47 additions & 12 deletions heaps/min_heap.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,32 @@ def __init__(self):
def add(self, key, value = None):
""" This method adds a HeapNode instance to the heap
If value == None the new node's value should be set to key
Time Complexity: ?
Space Complexity: ?
Time Complexity: O(log n)
Space Complexity: O(log n)
Comment on lines 21 to +25

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

"""
pass
if not value:
new_heapnode = HeapNode(key, key)
else:
new_heapnode = HeapNode(key, value)
self.store.append(new_heapnode)
index = len(self.store) - 1
self.heap_up(index)
return None

def remove(self):
""" This method removes and returns an element from the heap
maintaining the heap structure
Time Complexity: ?
Space Complexity: ?
Time Complexity: O(log n)
Space Complexity: O(1)
Comment on lines 36 to +40

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 However the space complexity is O(log n) due to the recursive heap_down method.

"""
pass
if self.empty():
return None

last_index = len(self.store) - 1
self.swap(0, last_index)
node_to_remove = self.store.pop(last_index)
self.heap_down(0)
return node_to_remove.value



Expand All @@ -49,7 +63,7 @@ def empty(self):
Time complexity: ?
Space complexity: ?
"""
pass
return len(self.store) == 0


def heap_up(self, index):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Expand All @@ -59,19 +73,40 @@ def heap_up(self, index):
property is reestablished.

This could be **very** helpful for the add method.
Time complexity: ?
Space complexity: ?
Time complexity: O(log n)
Space complexity: O(n)
"""
pass
if index == 0:
return index

parent_node = (index - 1) // 2
current_nodes = self.store
if current_nodes[parent_node].key > current_nodes[index].key:
self.swap(parent_node, index)
self.heap_up(parent_node)

def heap_down(self, index):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

""" This helper method takes an index and
moves the corresponding element down the heap if it's
larger than either of its children and continues until
the heap property is reestablished.
"""
pass

current_nodes = self.store
left_child_index = index * 2 + 1
right_child_index = index * 2 + 2

if left_child_index < len(self.store):
if right_child_index < len(current_nodes):
if current_nodes[left_child_index].key < current_nodes[right_child_index].key:
node = left_child_index
else:
node = right_child_index
else:
node = left_child_index

if current_nodes[index].key > current_nodes[node].key:
self.swap(index, node)
self.heap_down(node)

def swap(self, index_1, index_2):
""" Swaps two elements in self.store
Expand Down