Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heaps Paper Karla T #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions heaps/heap_sort.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,18 @@

from heaps.min_heap import MinHeap

def heap_sort(list):
""" This method uses a heap to sort an array.
Time Complexity: ?
Space Complexity: ?
Time Complexity: O(n)
Space Complexity: O(1)
"""
Comment on lines 3 to 7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The time complexity is O(n log n) because you're adding n nodes to the heap and each addition takes log n time.

Similarly the space complexity is O(n) because you build a heap of n nodes.

pass
heap = MinHeap()

for num in list:
heap.add(num)

index = 0

while not heap.empty():
list[index] = heap.remove()
index += 1
return list
51 changes: 40 additions & 11 deletions heaps/min_heap.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
class HeapNode:

def __init__(self, key, value):
self.key = key
self.value = value
Expand All @@ -21,19 +21,29 @@ def __init__(self):
def add(self, key, value = None):
""" This method adds a HeapNode instance to the heap
If value == None the new node's value should be set to key
Time Complexity: ?
Space Complexity: ?
Time Complexity: O(log n)
Space Complexity: O(log n)
"""
Comment on lines 21 to 26

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass
if value == None:
value = key

node = HeapNode(key, value)
self.store.append(node)
self.heap_up(len(self.store) -1)

def remove(self):
""" This method removes and returns an element from the heap
maintaining the heap structure
Time Complexity: ?
Space Complexity: ?
Time Complexity: O(log n)
Space Complexity: O(log n)
"""
Comment on lines 34 to 39

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pass
if len(self.store) == 0:
return
self.swap(0, len(self.store) - 1)
min = self.store.pop()
self.heap_down(0)

return min.value


def __str__(self):
Expand All @@ -49,7 +59,7 @@ def empty(self):
Time complexity: ?
Space complexity: ?
"""
pass
return len(self.store) == 0


def heap_up(self, index):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Time/space complexity should be O(log n)

Expand All @@ -62,16 +72,35 @@ def heap_up(self, index):
Time complexity: ?
Space complexity: ?
"""
pass
if index == 0:
return

parent = (index -1) // 2
if self.store[index].key < self.store[parent].key:
self.swap(index, parent)
self.heap_up(parent)


def heap_down(self, index):
""" This helper method takes an index and
moves the corresponding element down the heap if it's
larger than either of its children and continues until
the heap property is reestablished.
"""
pass

left_child = (2 * index) + 1
right_child = (2 * index) + 2

if left_child < len(self.store):
if right_child < len(self.store):
if self.store[left_child.key] < self.store[right_child].key:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if self.store[left_child.key] < self.store[right_child].key:
if self.store[left_child].key < self.store[right_child].key:

min_child = left_child
else:
min_child = right_child
else: min_child = left_child

if self.store[index].key > self.store[min_child.key]:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if self.store[index].key > self.store[min_child.key]:
if self.store[index].key > self.store[min_child].key:

self.swap(index, min_child)
self.heap_down(min_child)

def swap(self, index_1, index_2):
""" Swaps two elements in self.store
Expand Down