Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rock - Juliana DeCarvalho Sutherland #43

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

julianadecarvalho
Copy link

No description provided.

Copy link

@audreyandoy audreyandoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juliana! Great work on your personal website. I love all the images and fonts you added 🐻

I added some comments with feedback and styling recommendations. In addition, I know you've probably considered this but don't forget to add navigation to your other pages :P

Overall, great work Juliana!

Comment on lines +32 to +36
<h3>David Chu's China Bistro</h3>
<p>Final project for the HTML, CSS, & JavaScript for Web Developers from Johns Hopkins University on Coursera. Built a fully functional web app that used JavaScript and utilized Ajax.</p>
<a class="btn" href="https://julianadecarvalho.github.io/module5-solution/" target="_blank">Final Site</a>
<a class="btn" href="https://github.com/julianadecarvalho/johns-hopkins-fullstack-cousera-assignments" target="_blank">GitHub Repo</a>
</section>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project looks great! I'm glad you had prior exposure to HTML & CSS !

Comment on lines +40 to +44
<img src="images/david-chus.png" alt="Video Store CLI">
<h3>Video Store CLI</h3>
<p>RESTful routes</p>
<a class="btn" href="https://julianadecarvalho.github.io/module5-solution/" target="_blank">Final Site</a>
<a class="btn" href="https://github.com/julianadecarvalho/johns-hopkins-fullstack-cousera-assignments" target="_blank">GitHub Repo</a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links and images are still for David Chu's restaurant. Not sure if this was just filler for now until you have more time but thought I'd point it out just in case.

<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Juliana DeCarvalho Sutherland, Software Engineer Student + Full Stack Developer</title>
<link href="https://fonts.googleapis.com/css?family=Caveat|Montserrat:400,600&display=swap" rel="stylesheet">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of Google fonts! (: This font is super cute!

portfolio.html Outdated Show resolved Hide resolved
</head>
<body>


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add a lil navigation to head back to the home page if need be

Comment on lines +18 to +19
<p>Full-stack developer with a love for new technology, a curious mind for continuous learning, and a passion for solving complex problems in a creative way. I value diversity, inclusion, precision, and attention to detail. In my previous life, I worked with scientists across the globe to create open-source science and scientific materials accessible to all. This allowed me to build a strong foundation in collaboration, relationships, and communication skills.</p>
<p>I’m also exploring more creative pursuits with my photography & the love for the outdoors. <a href="https://www.instagram.com/j.by.the.bay/" target="_blank">j.by.the.bay</a></p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE the look of your bio with the bear background image 🐻❤️

It is a little hard to read the text so adding a background overlay (aka background color with opacity) would help the text contrast more and make it easier to read.

So you could surround the text with a div and a class like so:

Suggested change
<p>Full-stack developer with a love for new technology, a curious mind for continuous learning, and a passion for solving complex problems in a creative way. I value diversity, inclusion, precision, and attention to detail. In my previous life, I worked with scientists across the globe to create open-source science and scientific materials accessible to all. This allowed me to build a strong foundation in collaboration, relationships, and communication skills.</p>
<p>I’m also exploring more creative pursuits with my photography & the love for the outdoors. <a href="https://www.instagram.com/j.by.the.bay/" target="_blank">j.by.the.bay</a></p>
<div class="bio">
<p>Full-stack developer with a love for new technology, a curious mind for continuous learning, and a passion for solving complex problems in a creative way. I value diversity, inclusion, precision, and attention to detail. In my previous life, I worked with scientists across the globe to create open-source science and scientific materials accessible to all. This allowed me to build a strong foundation in collaboration, relationships, and communication skills.</p>
<p>I’m also exploring more creative pursuits with my photography & the love for the outdoors. <a href="https://www.instagram.com/j.by.the.bay/" target="_blank">j.by.the.bay</a></p>
</div>

Then add the following css:

.bio {
  width: 100%;
  margin: 0 1% 0 1%;
  padding: 1rem;
  height: 13rem;
  background-color: rgba(0,0,0,0.5);
} 

Would create the following effect:

Screen Shot 2021-06-29 at 12 23 59 PM

Co-authored-by: Audrey Andoy  <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants