Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maria M. - Scissors #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

maria-im015
Copy link

Stacks and Queues

Thanks for doing some brain yoga. You are now submitting this assignment!

Comprehension Questions

Question Answer
What is an ADT?
Describe a Stack
What are the 5 methods in Stack and what does each do?
Describe a Queue
What are the 5 methods in Queue and what does each do?
What is the difference between implementing something and using something?

OPTIONAL JobSimulation

Question Answer
Did you include a sample run of your code as a comment?

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work Maria, you hit the learning goals here. Well done. I couldn't find anything to suggest in ways of improvement.

Comment on lines +25 to +39
if self.size == self.buffer_size:
raise QueueFullException('Queue is full')

elif self.front == -1:
self.front = 0
self.rear = 0
self.store[self.rear] = element
self.size += 1
return self.store

else:
self.rear = (self.rear + 1) % self.buffer_size
self.store[self.rear] = element
self.size += 1
return self.store

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +47 to +54
if self.front == -1:
raise QueueEmptyException('Queue is empty')

else:
element = self.store[self.front]
self.front = (self.front + 1) % self.buffer_size
self.size -= 1
return element

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nicely done

Comment on lines +89 to +98

queue_list = []

if self.empty():
return str(queue_list)

for element in range(self.front, self.front + self.size):
element = element % self.buffer_size
queue_list.append(self.store[element])
return str(queue_list)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -12,7 +12,7 @@ def push(self, element):
""" Adds an element to the top of the Stack.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants