Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scissors - Aida R. #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Scissors - Aida R. #43

wants to merge 1 commit into from

Conversation

adia-9
Copy link

@adia-9 adia-9 commented Jan 2, 2022

Stacks and Queues

Thanks for doing some brain yoga. You are now submitting this assignment!

Comprehension Questions

Question Answer
What is an ADT? ADT is a representation of a data type, where only method is defined but not implementation
Describe a Stack It's an ADT that holds an ordered, linear sequence of items
What are the 5 methods in Stack and what does each do? push(), pop(), peak(), is_empty(), is_full()
Describe a Queue t's an ADT that holds an ordered collection of items where the addition of new items happens at one end - back, and the removal of existing items occurs at the other end, front
What are the 5 methods in Queue and what does each do? enqueue(), dequeue(), queue(), is_empty(), size()
What is the difference between implementing something and using something?

OPTIONAL JobSimulation

Question Answer
Did you include a sample run of your code as a comment?

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Aida, you hit the learning goals here. Well done.

@@ -15,47 +15,86 @@ def __init__(self):
self.front = -1
self.rear = -1
self.size = 0


def enqueue(self, element):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

self.rear = (self.rear + 1) % self.buffer_size
self.store[self.rear] = element
self.size += 1
return None

def dequeue(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

self.size -= 1
return temp
except:
raise QueueEmptyException("Error message")

def front(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

try:
return self.store[self.front]
except:
raise QueueEmptyException("Error message")

def size(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return self.size
except:
raise QueueEmptyException("Error message")


def empty(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I don't think you need to raise an exception here.

Comment on lines +75 to +78
try:
return self.size == 0
except:
raise QueueEmptyException("Error message")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
try:
return self.size == 0
except:
raise QueueEmptyException("Error message")
return self.size == 0

try:
return self.size == 0
except:
raise QueueEmptyException("Error message")

def __str__(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -12,7 +12,8 @@ def push(self, element):
""" Adds an element to the top of the Stack.
Returns None
"""
pass
self.store.add_last(element)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The stack functions work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants