Scissors Laurel O #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbieniosek
reviewed
Apr 12, 2021
|
|
||
| class Decor(Item): | ||
| def __init__(self, condition=0): | ||
| super().__init__("Decor", condition) |
Comment on lines
+30
to
+33
| self.inventory.remove(my_item) | ||
| them.inventory.append(my_item) | ||
| them.inventory.remove(their_item) | ||
| self.inventory.append(their_item) |
There was a problem hiding this comment.
Consider using the Vendor add & remove functions here.
| def swap_first_item(self, them): | ||
| if len(self.inventory) == 0 or len(them.inventory) == 0: | ||
| return False | ||
| return self.swap_items(them, self.inventory[0], them.inventory[0]) |
| items_in_category = self.get_by_category(category) | ||
| if len(items_in_category) > 0: | ||
| #lambda lets me define a func in a single line | ||
| return max(items_in_category, key = lambda item: item.condition) |
There was a problem hiding this comment.
Neat solution! I appreciate seeing all of the different versions in your commit history.
|
Great work on this project! Your code is very clean and readable. I had one minor comment about a place you could DRY up your code, but otherwise your use of helper functions throughout Vendor is excellent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.