Rock - Hannah Lumapas #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bute condition along with condition descriptions to each of the classes
…m of certain categories with another Vendor
…witch newest items by category. Also adds docstrings for better documentation.
…est items by category and swap newest items by category
spitsfire
reviewed
Apr 12, 2021
Comment on lines
+4
to
+26
| class Clothing(Item): | ||
| ''' | ||
| Represents a clothing Item | ||
| Attributes: | ||
| category (str) | ||
| condition (int/float) | ||
| age (int/float) | ||
| ''' | ||
| def __init__(self, category="", condition=0, age=0): | ||
| ''' | ||
| Inherits methods of the parent class Item | ||
| Parameters: | ||
| category ("Clothing") | ||
| condition (int/float) | ||
| age (int/float) | ||
| ''' | ||
| super().__init__("Clothing", condition, age) | ||
|
|
||
| def __str__(self): | ||
| ''' | ||
| Stringifies an instance of Clothing | ||
| ''' | ||
| return "The finest clothing you could wear." |
There was a problem hiding this comment.
👍 this looks great! let's try and clean up some of these docstring because there are a lot of them and it's harder to read it.
Suggested change
| class Clothing(Item): | |
| ''' | |
| Represents a clothing Item | |
| Attributes: | |
| category (str) | |
| condition (int/float) | |
| age (int/float) | |
| ''' | |
| def __init__(self, category="", condition=0, age=0): | |
| ''' | |
| Inherits methods of the parent class Item | |
| Parameters: | |
| category ("Clothing") | |
| condition (int/float) | |
| age (int/float) | |
| ''' | |
| super().__init__("Clothing", condition, age) | |
| def __str__(self): | |
| ''' | |
| Stringifies an instance of Clothing | |
| ''' | |
| return "The finest clothing you could wear." | |
| ''' | |
| Represents a clothing Item and Inherits methods of the parent class Item | |
| ''' | |
| class Clothing(Item): | |
| def __init__(self, condition=0, age=0): | |
| super().__init__("Clothing", condition, age) | |
| def __str__(self): | |
| return "The finest clothing you could wear." |
so, because Clothing class category will always be "clothing," we don't need to give the user the ability to change that in this situation.
also, I've cleaned up the docstring and fir the important bits under one docstring
| from swap_meet.item import Item | ||
|
|
||
| # ---- Wave 5 ----- # | ||
| class Decor(Item): |
There was a problem hiding this comment.
👍 as above, think about summarizing your comments into one docstring
| condition (int/float) | ||
| age (int/float) | ||
| ''' | ||
| def __init__(self, category="", condition=0, age=0): |
There was a problem hiding this comment.
Suggested change
| def __init__(self, category="", condition=0, age=0): | |
| def __init__(self, condition=0, age=0): |
| @@ -0,0 +1,46 @@ | |||
| # ---- Wave 2 ----- # | |||
| class Item: | |||
| from swap_meet.item import Item | ||
|
|
||
| # ---- Wave 1 ----- # | ||
| class Vendor: |
| return swapped | ||
|
|
||
| # ---- Wave 4 ----- # | ||
| def swap_first_item(self, friend): |
There was a problem hiding this comment.
👍 great to see you'rereusingg swap_items
Comment on lines
+103
to
+111
| category_items = self.get_by_category(category) | ||
| items_conditions = [] | ||
| best_item = None | ||
| for item in category_items: | ||
| items_conditions.append(item.condition) | ||
| best_condition = max(items_conditions) | ||
| if best_condition == item.condition: | ||
| best_item = item | ||
| return best_item |
There was a problem hiding this comment.
so this works! But there's a lot of for loops going on here. 1 from get_by_category, 1 in the code, and at least 1 in max method under the hood.
Suggested change
| category_items = self.get_by_category(category) | |
| items_conditions = [] | |
| best_item = None | |
| for item in category_items: | |
| items_conditions.append(item.condition) | |
| best_condition = max(items_conditions) | |
| if best_condition == item.condition: | |
| best_item = item | |
| return best_item | |
| category_items = self.get_by_category(category) | |
| best_item = category_items[0] | |
| for item in category_items: | |
| if item.condition > best_item.condition: | |
| best_item = item | |
| return best_item |
| best_item = item | ||
| return best_item | ||
|
|
||
| def swap_best_by_category(self, other, my_priority, their_priority): |
Comment on lines
+135
to
+143
| category_items = self.get_by_category(category) | ||
| items_ages = [] | ||
| newest_item = None | ||
| for item in category_items: | ||
| items_ages.append(item.age) | ||
| newest_age = max(items_ages) | ||
| if newest_age == item.age: | ||
| newest_item = item | ||
| return newest_item |
There was a problem hiding this comment.
we can change this up like we did above on lines 103 - 111
| newest_item = item | ||
| return newest_item | ||
|
|
||
| def swap_newest_by_category(self, other, my_priority, their_priority): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.