Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary search trees #34

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

binary search trees #34

wants to merge 4 commits into from

Conversation

Raque-lita
Copy link

WOOF! I am struggling with trees! Slowly making some sense but maybe I can ask you about post order, I strugged with figuring out where to put the append....

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Raquel, you hit the learning goals here. Well done. I left a few minor comments, but this is a strong submission.

if val == None:
val = key

self.key = key
self.value = val
self.left = None
self.right = None


def height(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting putting this on the TreeNode class.

Comment on lines +91 to +93
# Time Complexity: O(n)
# Space Complexity:O(n)
def preorder_helper(self, current, traversal_list):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +117 to 120
# Time Complexity: O(n)
# Space Complexity: O(n)

# Time Complexity:
# Space Complexity:
def postorder(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +75 to +77
# Time Complexity: O(n)
# Space Complexity: O(n)
def inorder_helper(self, current, traversal_list):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +26 to +29
# Time Complexity: O(log N)
# Space Complexity: O(1)

def add_helper(self, current_node, key, value):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The space complexity is O(log n) if the tree is balanced due to the recursive call stack.

Comment on lines +58 to 60
# Time Complexity: O(n)
# Space Complexity: O(1)
def find(self, key):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants