Rock - Abigail C #50
Open
Rock - Abigail C #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audreyandoy
reviewed
Apr 2, 2021
| new_movie = {} | ||
| if movie_title == None or genre == None or rating == None: | ||
| new_movie = None | ||
| else: |
There was a problem hiding this comment.
you could also rewrite to build the dictionary like so
new_move = {
"title": movie_title,
"genre": genre,
"rating": rating
}
| for movie in user_data['watched']: | ||
| genre = movie['genre'] | ||
| genre_list.append(genre) | ||
| popular_genre = max(set(genre_list), key = genre_list.count) |
There was a problem hiding this comment.
Hey Abigail, that is great! I'm glad you're utilizing more advanced methods and data structures. However, in the future, please add a comment that describes code that isn't covered in our curriculum.
Comment on lines
+104
to
+128
| friend_data = get_friend_titles(user_data) | ||
| recommendations = [] | ||
| friend_data = remove_duplicates(friend_data) | ||
| for data in friend_data: | ||
| if data['host'] in user_data["subscriptions"]: | ||
| recommendations.append(data) | ||
| return recommendations | ||
|
|
||
| # Wave 5 | ||
| def get_new_rec_by_genre(user_data): | ||
| user_titles = get_user_titles(user_data) | ||
| friends_titles = get_friend_titles(user_data) | ||
| recommendations = [] | ||
| if user_titles == []: | ||
| recommendations = [] | ||
| else: | ||
| for title in friends_titles: | ||
| if title not in user_titles: | ||
| recommendations.append(title) | ||
| return recommendations | ||
|
|
||
| def get_rec_from_favorites(user_data): | ||
| user_titles = get_user_titles(user_data) | ||
| friends_titles = get_friend_titles(user_data) | ||
| for movie in friends_titles: |
audreyandoy
reviewed
Apr 2, 2021
Comment on lines
+12
to
+26
| def add_to_watched(user_data, movie): | ||
| user_data = { | ||
| "watched":[ | ||
| movie | ||
| ] | ||
| } | ||
| return user_data | ||
|
|
||
| def add_to_watchlist(user_data, movie): | ||
| user_data = { | ||
| "watchlist":[ | ||
| movie | ||
| ] | ||
| } | ||
| return user_data |
There was a problem hiding this comment.
One way to refactor this so the movie is actually being added is user_data["watched"].append(movie)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.