Scissors - Mai Truong #55
Conversation
| @@ -0,0 +1,15 @@ | |||
| { | |||
There was a problem hiding this comment.
In the future if you use git add main.py instead of git add . you can leave files like this out of your commits.
|
|
||
| def create_movie(movie_title, genre, rating): | ||
| # create dictionary | ||
| new_movies = { |
There was a problem hiding this comment.
Since this is only one movie, it'd be more appropriately named new_movie
| # if len(user_data["watched"]) == 0: | ||
| # return [] |
There was a problem hiding this comment.
In the future, your submissions can be a little cleaner by removing old code like this
| most_watched[movie["genre"]] = 1 | ||
| else: | ||
| most_watched[movie["genre"]] += 1 | ||
| popular_genre = max(most_watched, key = most_watched.get) |
There was a problem hiding this comment.
Because of the indentation, popular_genre is currently being calculated at each iteration of the loop even though you don't need it until the end.
| popular_genre = max(most_watched, key = most_watched.get) | |
| popular_genre = max(most_watched, key = most_watched.get) |
| def get_rec_from_favorites(user_data): | ||
|
|
||
| user_favories = user_data["favorites"] | ||
| friends_movies = user_data["friends"] | ||
| favorites = [] | ||
| user_rec = [] | ||
|
|
||
| for movie in user_favories: | ||
| favorites.append(movie) | ||
|
|
||
| for movie in favorites: | ||
| for movie in friends_movies["watched"]: | ||
| # if movie not in friends_movies["watched"]: | ||
| user_rec.append(movie) | ||
|
|
||
| return user_rec | ||
|
|
||
| def get_rec_from_favorites(user_data): | ||
|
|
||
| user_favories = user_data["favorites"] | ||
| friends_movies = user_data["friends"] | ||
| favorites = [] | ||
| friend_watched = [] | ||
| user_rec = [] | ||
|
|
||
| for movie in user_favories: | ||
| favorites.append(movie) | ||
|
|
||
| for friend in friends_movies: | ||
| for movie in friend["watched"]: | ||
| friend_watched.append(movie) | ||
|
|
||
| for movies in favorites: | ||
| if movies not in friend_watched: | ||
| user_rec.append(movies) | ||
|
|
||
| return user_rec |
There was a problem hiding this comment.
I'm curious why this same function is defined twice.
In this case the first function definition will just get overwritten by the 2nd one.
No description provided.