Paper - Brittney Payne #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Mar 30, 2021
| # test 2 if title returns none function returns none | ||
| # test 3 if genre returns none function returns none | ||
| # test 4 if rating returns none function returns none | ||
| def create_movie(movie_title, genre, rating): |
|
|
||
| # test 5 funct to add movie to "watched" list, takes in | ||
| # user data (list of dict) and a movie dict returns new list | ||
| def add_to_watched(user_data, movie): |
|
|
||
| # test 6 func to add movie to watchlist, takes in user data (list of dict) | ||
| # and a movie dict and returns the new list | ||
| def add_to_watchlist(user_data, movie): |
| # test 8 moves a movie from watched list to watchlist when watchlist is truthy | ||
|
|
||
| # test 9 function does nothing if movie title is not in watched list | ||
| def watch_movie(user_data, title): |
| # test 10 funct for avg rating that takes in user_data returns avg of ratings | ||
|
|
||
| # # test 11 function returns 0.0 if no movies in watched list | ||
| def get_watched_avg_rating(user_data): |
There was a problem hiding this comment.
👍 , nice use of a list comprehension!
| # watched all the movies friends have watched. | ||
|
|
||
|
|
||
| def get_friends_unique_watched(user_data): |
| # c: the host of the movie is in the users "subscriptions" | ||
|
|
||
| # test 20 ensure you return an empty list if there are no intersections | ||
| def get_available_recs(user_data): |
There was a problem hiding this comment.
👍 , This has a pretty deep list comprehension. It's good practice, but be a little careful if the logic is getting too twisted for readability's sake.
Comment on lines
+175
to
+176
| most_watched_genre = get_most_watched_genre(user_data) | ||
| friends_watched_user_has_not = get_friends_unique_watched(user_data) |
There was a problem hiding this comment.
Good reuse of functions.
| # movies in watch list | ||
|
|
||
|
|
||
| def get_new_rec_by_genre(user_data): |
| # of recco movies that should be added to the list only if in users | ||
| # favorites and if none of the friends have watched. | ||
|
|
||
| def get_rec_from_favorites(user_data): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.