Scissors - Ivana #58
Open
Scissors - Ivana #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Great work on your first Ada project! You've met the learning goals of working with loops, conditionals, and nested data structures. Your code is clear and concise, and makes good use of helper functions. I've made a couple suggestions that we can discuss in your 1:1 this week. Keep up the hard work!
GREEN
| # test_wave_01 | ||
|
|
||
| def create_movie(movie_title=str, genre=str, rating=float): | ||
| """Creates a ``new_movie`` that will be added to the user's list. |
There was a problem hiding this comment.
Nice use of docstrings throughout
|
|
||
| # NEW: Helper function: gets the movies all friends watched. | ||
|
|
||
| def get_friends_movies(user_data): |
There was a problem hiding this comment.
Great use of a helper function to DRY up your code!
Comment on lines
+239
to
+240
| friends_movies = get_friends_movies(user_data) | ||
| fav_genre = get_most_watched_genre(user_data) |
There was a problem hiding this comment.
Great work using the previous functions as helper function to write clear, concise code
Return the default rating first to deal with the edge case first to improve efficiency Co-authored-by: Becca <[email protected]>
Change the assignment operator for better readability Co-authored-by: Becca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.