Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewing-party Delia Rock #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Parseluni
Copy link

Final version

Copy link

@spitsfire spitsfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very easy to understand and read! very clean, too! Great job!

@@ -0,0 +1,147 @@
# WAVE 1

def create_movie(title, genre, rating):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

viewing_party/main.py Outdated Show resolved Hide resolved
return None
return movie

def add_to_watched(user_data, movie):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

user_data["watched"].append(movie)
return user_data

def add_to_watchlist(user_data, movie):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

user_data["watchlist"].append(movie)
return user_data

def watch_movie(user_data, title):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

unique_watched.append(title)
return unique_watched

def get_friends_unique_watched(user_data):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


# WAVE 4

def get_available_recs(user_data):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


# WAVE 5

def get_new_rec_by_genre(user_data):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

user_movie_genres.append(movie["genre"])

# determine user's favorite genre
user_fave_genre = get_most_watched_genre(user_data)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea reusing a function you've made!

new_rec_by_genre.append(movie)
return new_rec_by_genre

def get_rec_from_favorites(user_data):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Checking if parameters are valid before running a for loop.

Co-authored-by: Claire Elliott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants